[metricbeat] check for a valid limit before we process a memory event #11676
Conversation
fearful-symmetry
added
bug
module
Metricbeat
|
+1 It would be probably very expensive to Not needed, but a bit more awesomeness and love if setting a proper variable name to something like |
|
@odacremolbap Yah, I kinda gave those variable name the side-eye earlier too. |
| @@ -22,6 +22,7 @@ import ( | |||
| "github.com/elastic/beats/metricbeat/module/docker" | |||
| ) | |||
|
|
|||
| //MemoryData contains parsed container memory info | |||
There was a problem hiding this comment.
a space here would be great :-) "// MemoryData..." and same in line 38
|
Can you add a changelog entry? Also added |
ruflin
added
needs_backport
|
Looks like coredns is failing here now too: |
|
Let's try to rebase. |
fearful-symmetry
force-pushed
the
docker-memory-nan
branch
from
3b7511c
to
6cad5e7
Compare
…elastic#11676) * check for a valid limit before we process a memory event (cherry picked from commit 97aec9b)
…elastic#11676) * check for a valid limit before we process a memory event (cherry picked from commit 97aec9b)
|
It seems it was already backported, I am removing the needs_backport label. |
jsoriano
removed
the
needs_backport
This fixes #11283
It appears that we can get a stat object back when a container is in some odd in between state where it's not actually started. During this time, all the memory values we're using are zero, and we get NaNs from the division operations:
The docker source states that
Limitwill only be 0 if a container isn't started, so we use that to check if we have a valid event. We can also process the event and just wrap the division inifblocks, but I liked the idea of skipping the event if we have zero'ed out data.